Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Mar 15, 2022

Closes #2464 .

One small thing that I realized in this PR is that if we define a test like this:

class X_foo(rfm.RunOnlyRegressionTest):
    a = parameter(['a', 'b', 'c'])
    ...

we can rerun it with -n X@foo@1 when compact_test_names=True, because of this code https://github.com/eth-cscs/reframe/blob/master/reframe/frontend/filters.py#L29 . Should I leave it as it is or do we want to change the bahaviour there as well?

@ekouts ekouts added this to the ReFrame sprint 22.03.1 milestone Mar 15, 2022
@ekouts ekouts requested review from teojgo and vkarak March 15, 2022 12:07
@ekouts ekouts self-assigned this Mar 15, 2022
@ekouts ekouts changed the title Make rerun prompt consistent with the name filter for compact_test_names [bugfix] Make rerun prompt consistent with the name filter for compact_test_names Mar 15, 2022
@vkarak vkarak changed the title [bugfix] Make rerun prompt consistent with the name filter for compact_test_names [bugfix] Make rerun prompt consistent with the new naming scheme Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #2471 (8ea201a) into master (8aed4f5) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 8ea201a differs from pull request most recent head 36ab789. Consider uploading reports for the commit 36ab789 to get more accurate results

@@            Coverage Diff             @@
##           master    #2471      +/-   ##
==========================================
- Coverage   85.71%   85.69%   -0.03%     
==========================================
  Files          56       56              
  Lines       10529    10534       +5     
==========================================
+ Hits         9025     9027       +2     
- Misses       1504     1507       +3     
Impacted Files Coverage Δ
reframe/frontend/statistics.py 94.63% <50.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a446bfc...36ab789. Read the comment docs.

@vkarak vkarak merged commit 2db7e2f into reframe-hpc:master Mar 15, 2022
@ekouts ekouts deleted the bugfix/rerun_name branch May 18, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rerun prompt is not consistent with the name filter

3 participants