[refactor] Refactor fixture instantiation #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixtures are instantiated in the `instantiate_all()` method of the `TestRegistry`.
ekouts
approved these changes
Mar 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 57 57
Lines 10544 10544
=======================================
Hits 9037 9037
Misses 1507 1507
Continue to review full report at Codecov.
|
teojgo
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixtures are instantiated in the
instantiate_all()method of theTestRegistry. This will allow us to use theTestRegistry.instantiate_all()to instantiate all the tests and their fixtures that will be dynamically generated in #2458.