Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Mar 17, 2022

Fixes #2466

@teojgo teojgo added this to the ReFrame sprint 22.03.1 milestone Mar 17, 2022
@teojgo teojgo requested review from victorusu and vkarak March 17, 2022 13:56
@teojgo teojgo self-assigned this Mar 17, 2022
@teojgo
Copy link
Contributor Author

teojgo commented Mar 17, 2022

@giordano I could reproduce your issue. Can you check that it's fixed by this?

@giordano
Copy link
Contributor

Yes, I can confirm the reproducer in #2466 works for me with this PR, thanks!

@vkarak
Copy link
Contributor

vkarak commented Mar 18, 2022

@teojgo This was regression indeed in ReFrame and, in fact, we used to set stdin to DEVNULL as a fix of #1877 in #1879. This was accidentally removed in #2383. @teojgo could have a unit test to reproduce this? #1877 has a reproducer that's not relying on Spack. We could add a unit test for it.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #2476 (a053a30) into master (f44e37c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a053a30 differs from pull request most recent head 9793e74. Consider uploading reports for the commit 9793e74 to get more accurate results

@@           Coverage Diff           @@
##           master    #2476   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files          57       57           
  Lines       10544    10545    +1     
=======================================
+ Hits         9037     9038    +1     
  Misses       1507     1507           
Impacted Files Coverage Δ
reframe/utility/osext.py 84.42% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44e37c...9793e74. Read the comment docs.

This reverts commit a053a30.
@vkarak vkarak changed the title [bugfix] Default to DEVNULL for Popen in run_command_async [bugfix] Fix regression with tests that treat stdin as a tty Mar 18, 2022
@vkarak vkarak merged commit 39984b7 into reframe-hpc:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spack build system is broken

4 participants