Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Mar 29, 2022

The problem we have faced trying to implement the OSU benchmarks as a library in #2421 is that in the CSCS specialisation we wanted to set the valid_systems and valid_prog_environs based on the osu_binaries.build_type fixture parameter. This was only possible to achieve by creating explicitly different specialized tests for each build type, because we were not allowed to access fixtures before the setup stage. This PR solves this, allowing users to access fixtures as early as in a post-init hook. However, only fixture parameters are allowed to be accessed at this point, but it should be enough to serve us in almost all if not all scenarios. From the setup stage onward, there is no change in the behaviour compared to the past.

@vkarak vkarak added this to the ReFrame Sprint 22.03.2 milestone Mar 29, 2022
@vkarak vkarak requested review from ekouts and victorusu March 29, 2022 09:01
@vkarak vkarak self-assigned this Mar 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@d476c21). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 6ef689c differs from pull request most recent head 5efae90. Consider uploading reports for the commit 5efae90 to get more accurate results

@@            Coverage Diff            @@
##             master    #2484   +/-   ##
=========================================
  Coverage          ?   85.73%           
=========================================
  Files             ?       57           
  Lines             ?    10554           
  Branches          ?        0           
=========================================
  Hits              ?     9048           
  Misses            ?     1506           
  Partials          ?        0           
Impacted Files Coverage Δ
reframe/core/pipeline.py 93.49% <ø> (ø)
reframe/core/fixtures.py 100.00% <100.00%> (ø)
reframe/core/meta.py 99.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d476c21...5efae90. Read the comment docs.

@vkarak vkarak merged commit a3a94fb into reframe-hpc:master Mar 30, 2022
@vkarak vkarak deleted the feat/early-fixture-access branch March 30, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants