Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 11, 2022

Fixes #2473

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are touching the buildsystems, can you change the remaining string formatting which uses % to f=strings?

@codecov-commenter
Copy link

Codecov Report

Merging #2494 (21a76cb) into master (098ff00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 21a76cb differs from pull request most recent head ea457f5. Consider uploading reports for the commit ea457f5 to get more accurate results

@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files          57       57           
  Lines       10686    10690    +4     
=======================================
+ Hits         9168     9172    +4     
  Misses       1518     1518           
Impacted Files Coverage Δ
reframe/core/buildsystems.py 96.26% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098ff00...ea457f5. Read the comment docs.

@vkarak vkarak requested a review from teojgo April 12, 2022 13:13
@vkarak vkarak merged commit 8c178ab into reframe-hpc:master Apr 12, 2022
@vkarak vkarak deleted the feat/custom-build-system branch April 12, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a minimal Custom build system

4 participants