[feat] Add --mode option to GitLab CI pipeline command
#2514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
requested changes
May 18, 2022
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I wouldn't add a configuration parameter to select the mode. Given that we already define the modes having another parameter to control which mode to select can be confusing. I suggest removing that and instead passing the mode options to the emit_pipeline() function with an argument named child_pipeline_opts. We will also need to expand the documentation of the --ci-generate option and feature and explain which options are passed through always and how a user can options to the reframe invocation in the child pipeline.
vkarak
reviewed
May 20, 2022
|
|
||
|
|
||
| def _emit_gitlab_pipeline(testcases): | ||
| def _emit_gitlab_pipeline(testcases, child_pipeline_opts): |
Contributor
There was a problem hiding this comment.
Suggested change
| def _emit_gitlab_pipeline(testcases, child_pipeline_opts): | |
| def _emit_gitlab_pipeline(testcases, child_pipeline_opts=None): |
And avoid having to change the unit test.
vkarak
reviewed
May 23, 2022
vkarak
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2467