[feat] Allow user defined launchers in the configuration #2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
requested changes
Sep 28, 2022
… feat/custom_launcher
Codecov ReportBase: 86.68% // Head: 86.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
- Coverage 86.68% 86.26% -0.43%
==========================================
Files 59 60 +1
Lines 10869 10962 +93
==========================================
+ Hits 9422 9456 +34
- Misses 1447 1506 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
teojgo
approved these changes
Sep 29, 2022
vkarak
approved these changes
Oct 3, 2022
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I did some fine tuning to the docs and lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @giordano 's suggestion I removed the schema restriction and added an example in the documentation.
Closes #2560 .
@jgphpc @teojgo this will also make it easier for us to test on hohgant