[feat] Change default value of num_gpus_per_node to None
#2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
requested changes
Oct 20, 2022
ekouts
approved these changes
Oct 21, 2022
Contributor
|
@jenkins-cscs retry daint |
vkarak
changed the title
num_gpus_per_node to Nonenum_gpus_per_node to None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to match the rest of non-required resource-related variables that default to
None. This will also makenum_gpus_per_nodedisappear from the new performance report, if it is not set, as it happens with the rest of the variables.