Skip to content

[feat] Change default value of num_gpus_per_node to None #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2022
Merged

[feat] Change default value of num_gpus_per_node to None #2638

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dceb977
Change default value for `num_gpus_per_node` to `None`
vkarak Oct 19, 2022
833698a
Address PR comments
vkarak Oct 20, 2022
f2ef31a
Merge branch 'master' into feat/num-gpus-per-node-default
vkarak Oct 21, 2022
b9e1b00
Merge branch 'master' into feat/num-gpus-per-node-default
vkarak Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,9 +556,12 @@ def pipeline_hooks(cls):
#: For more information on test resources, have a look at the
#: :attr:`extra_resources` attribute.
#:
#: :type: integral
#: :default: ``0``
num_gpus_per_node = variable(int, value=0, loggable=True)
#: :type: integral or :const:`None`
#: :default: :const:`None`
#:
#: .. versionchanged:: 4.0.0
#: The default value changed to :const:`None`.
num_gpus_per_node = variable(int, type(None), value=None, loggable=True)

#: Number of CPUs per task required by this test.
#:
Expand Down Expand Up @@ -1890,7 +1893,7 @@ def _get_cp_env():
environs.insert(2, cp_env)

# num_gpus_per_node is a managed resource
if self.num_gpus_per_node > 0:
if self.num_gpus_per_node:
self.extra_resources.setdefault(
'_rfm_gpu', {'num_gpus_per_node': self.num_gpus_per_node}
)
Expand Down