Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Oct 21, 2022

For this I guess with should change the name of the function since it has cdt. Maybe cray_pe_version and deprecate cray_cdt_version ?

@codecov-commenter
Copy link

Codecov Report

Base: 86.26% // Head: 86.27% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1901ac7) compared to base (e90be6d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2644   +/-   ##
=======================================
  Coverage   86.26%   86.27%           
=======================================
  Files          60       60           
  Lines       10990    10992    +2     
=======================================
+ Hits         9481     9483    +2     
  Misses       1509     1509           
Impacted Files Coverage Δ
reframe/utility/osext.py 84.67% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, besides a small typo. I am also not sure if we should rename the function. If we do we will also have to update all the reframe tests that use it.

Co-authored-by: Eirini Koutsaniti <eirini.koutsaniti@cscs.ch>
@rsarm rsarm requested a review from victorusu October 21, 2022 12:08
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR lgtm, but generally, I think that the use of this function, in general should be deprecated in favor of the new syntax of valid_prog_environs that can match environments based on features and extras. That function and, probably similar ones in the future should be called from a feature autodetection mechanism from the framework. I think also that CSCS' config and tests should move towards that direction abandoning the use of explicit system names and environments in the valid_systems and valid_prog_environs.

@vkarak vkarak changed the title [feat] Extend functionality to get the Cray's CDT version to support systems based on the CPE module [feat] Extend cray_cdt_version utility function to recognise CPE versions too Oct 21, 2022
@vkarak vkarak changed the title [feat] Extend cray_cdt_version utility function to recognise CPE versions too [feat] Extend cray_cdt_version() utility function to recognise CPE versions too Oct 21, 2022
@vkarak vkarak merged commit 8efea83 into reframe-hpc:master Oct 21, 2022
@rsarm rsarm deleted the osext-cdt-version branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants