[feat] Introduce variable aliases #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This practically extends on the field aliasing that we used to have and brings the same concept to variables. Users can now define a variable as an alias of another one. This is quite useful for transitional periods and deprecations when a variable is renamed. This commit also introduces implementation improvements on how variables are inherited.
victorusu
reviewed
Oct 27, 2022
1 task
Contributor
teojgo
approved these changes
Nov 3, 2022
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
lgtm, I only have a question. Is the null string the default one when the alias is not loggable? I couldn't find where it comes from
Contributor
Author
The alias get their default value from their target. See the |
Contributor
|
@jenkins-cscs retry all |
teojgo
approved these changes
Nov 4, 2022
Contributor
Ok, yeah it was difficult to find where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This practically extends on the field aliasing that we used to have and brings the same concept to variables. Users can now define a variable as an alias of another one. This is quite useful for transitional periods and deprecations when a variable is renamed. An aliased can be defined as follows:
The variable
ymay not have a default value, but it can be independently loggable. Any update of variablexwill be visible toyand vice versa. Aliased variables can refer also to inherited variables.This feature is useful for transitional periods when a variable is renamed and a deprecation is introduced and we want to keep both names for a while. The new variable can also be wrapped with
deprecate()to mark a deprecation. This allows us to introduces variable aliases and deprecations effortlessly.This commit also introduces implementation improvements on how variables are inherited. In particular, inherited variables are no more set redundantly as they are being inherited by classes lower in the hierarchy.