-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Deprecate variables in favour of the new env_vars
#2648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The deprecation is valid everywhere: from the configuration to the tests.
Codecov ReportBase: 86.27% // Head: 86.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2648 +/- ##
==========================================
+ Coverage 86.27% 86.30% +0.02%
==========================================
Files 60 60
Lines 10992 11081 +89
==========================================
+ Hits 9483 9563 +80
- Misses 1509 1518 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c5491d4 to
385e5ad
Compare
|
Out of curiosity, what changed since #1774 (comment)
? |
We were quite ambivalent with this change to be honest, but since 4.0 is a major version bump, we eventually thought that it's probably the right moment to introduce such a change. After all, all it requires is a search-and-replace. Deprecating FYI, though, there is a bug in the master regarding the use of |
The use of
variablesis deprecated in both the configuration and the tests. Users should useenv_varsinstead.This PR builds on top of #2647.
Closes #1774.
Todos