Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Oct 29, 2022

The use of variables is deprecated in both the configuration and the tests. Users should use env_vars instead.

This PR builds on top of #2647.

Closes #1774.

Todos

  • Update tutorial examples

The deprecation is valid everywhere: from the configuration to the tests.
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Base: 86.27% // Head: 86.30% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (30284d7) compared to base (425a14d).
Patch coverage: 90.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
+ Coverage   86.27%   86.30%   +0.02%     
==========================================
  Files          60       60              
  Lines       10992    11081      +89     
==========================================
+ Hits         9483     9563      +80     
- Misses       1509     1518       +9     
Impacted Files Coverage Δ
reframe/core/systems.py 89.95% <ø> (ø)
reframe/frontend/cli.py 72.30% <0.00%> (-0.12%) ⬇️
reframe/frontend/runreport.py 94.61% <33.33%> (-0.70%) ⬇️
reframe/frontend/statistics.py 96.06% <83.33%> (+0.06%) ⬆️
reframe/core/environments.py 94.82% <85.71%> (-1.57%) ⬇️
reframe/core/variables.py 95.75% <94.28%> (-0.56%) ⬇️
reframe/core/config.py 91.82% <96.15%> (+0.28%) ⬆️
reframe/core/logging.py 77.12% <100.00%> (+0.11%) ⬆️
reframe/core/meta.py 99.08% <100.00%> (ø)
reframe/core/pipeline.py 93.41% <100.00%> (+<0.01%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak force-pushed the feat/deprecate-variables branch from c5491d4 to 385e5ad Compare October 30, 2022 21:39
@vkarak vkarak marked this pull request as draft October 30, 2022 23:04
@vkarak vkarak marked this pull request as ready for review October 30, 2022 23:25
@vkarak vkarak merged commit 1e821f5 into reframe-hpc:master Nov 17, 2022
@vkarak vkarak deleted the feat/deprecate-variables branch November 17, 2022 17:04
@giordano
Copy link
Contributor

Out of curiosity, what changed since #1774 (comment)

As discussed, we will not deprecate variables because this would cause a major disruption.

?

@vkarak
Copy link
Contributor Author

vkarak commented Nov 22, 2022

Out of curiosity, what changed since #1774 (comment)

We were quite ambivalent with this change to be honest, but since 4.0 is a major version bump, we eventually thought that it's probably the right moment to introduce such a change. After all, all it requires is a search-and-replace. Deprecating perf_patterns in favour of @performance_functions on the other hand would be more tedious for the users, so atm we choose not to do so and just update the docs.

FYI, though, there is a bug in the master regarding the use of variables (see #2681). We will fix this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace variables with env_vars

4 participants