Skip to content

[feat] Print better error message when pygelf cannot be imported #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2022
Merged

[feat] Print better error message when pygelf cannot be imported #2691

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd9416f
Print better error message when pygelf cannot be imported
vkarak Nov 25, 2022
aaf5d20
Merge branch 'master' into enhacement/improve-graylog-error-msg
vkarak Dec 5, 2022
96cde9e
Merge branch 'master' into enhacement/improve-graylog-error-msg
vkarak Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion reframe/core/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ def _create_stream_handler(site_config, config_prefix):
def _create_graylog_handler(site_config, config_prefix):
try:
import pygelf
except ImportError:
except ImportError as err:
getlogger().warning(f'could not import pygelf module: {err}')
return None

address = site_config.get(f'{config_prefix}/address')
Expand Down