Skip to content

Remove 'post_run' and 'pre_run' from 'Job' #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Remove 'post_run' and 'pre_run' from 'Job' #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19fbfb0
Remove 'post_run' and 'pre_run' from 'Job'
Apr 30, 2018
b321caa
Merge branch 'master' into enhancement/remove_post_pre_run
vkarak Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions reframe/core/schedulers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,34 +41,6 @@ class Job(abc.ABC):
#: :default: ``[]``
options = fields.TypedListField('options', str)

#: List of shell commands to execute before launching this job.
#:
#: :type: :class:`list` of :class:`str`
#: :default: ``[]``
#:
#: .. note::
#: .. deprecated:: 2.10
#: Please use the :attr:`reframe.core.pipeline.RegressionTest.pre_run`
#: field instead.
pre_run = fields.DeprecatedField(
fields.TypedListField('_pre_run', str),
'Use of the pre_run field of Job is deprecated. '
'Please use the pre_run field of RegressionTest instead.')

#: List of shell commands to execute after launching this job.
#:
#: :type: :class:`list` of :class:`str`
#: :default: ``[]``
#:
#: .. note::
#: .. deprecated:: 2.10
#: Please use the :attr:`reframe.core.pipeline.RegressionTest.post_run`
#: field instead.
post_run = fields.DeprecatedField(
fields.TypedListField('_post_run', str),
'Use of the post_run field of Job is deprecated. '
'Please use the post_run field of RegressionTest instead.')

#: The parallel program launcher that will be used to launch the parallel
#: executable of this job.
#:
Expand Down
10 changes: 0 additions & 10 deletions unittests/test_schedulers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,16 +225,6 @@ def test_cancel_term_ignore(self):
# Verify that the spawned sleep is killed, too
self.assertProcessDied(sleep_pid)

def test_deprecated_pre_run_and_post_run(self):
from reframe.core.exceptions import ReframeDeprecationWarning

self.assertWarns(ReframeDeprecationWarning, exec,
'self.testjob.pre_run = []',
globals(), locals())
self.assertWarns(ReframeDeprecationWarning, exec,
'self.testjob.post_run = []',
globals(), locals())


class TestSlurmJob(_TestJob):
@property
Expand Down