Skip to content

Fix force local execution #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2018
Merged

Fix force local execution #274

merged 2 commits into from
Apr 30, 2018

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 30, 2018

  • Add Unit test to expose the bug.

Fixes #216.

Fix force local execution
c661671 
- Add Unit test to expose the bug.
@vkarak vkarak added this to the ReFrame sprint 2018w16 milestone Apr 30, 2018
@vkarak vkarak self-assigned this Apr 30, 2018
@vkarak vkarak requested review from teojgo and victorusu April 30, 2018 09:27
teojgo
teojgo approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and it works

@vkarak vkarak merged commit 54411e4 into reframe-hpc:master Apr 30, 2018
@vkarak vkarak deleted the bugfix/force-local-not-working branch April 30, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teojgo teojgo teojgo approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@vkarak vkarak

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 2018w16

Development

Successfully merging this pull request may close these issues.

2 participants

@vkarak @teojgo