-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Allow custom HTTP headers with the httpjson log handler
#2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can I test this patch? |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to add this to the configuration schema as well.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2854 +/- ##
===========================================
- Coverage 86.93% 86.89% -0.05%
===========================================
Files 60 60
Lines 11505 11500 -5
===========================================
- Hits 10002 9993 -9
- Misses 1503 1507 +4
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gonna add it as |
|
Documentation should be updated as well |
|
@teojgo , The PR now follows the community guidelines and the schema has been updated. As far as I have seen, no test is included for |
@Lewih Thanks for the PR and the update. Yes, we don't have any testing for the handler at the moment but suggestions are always welcome. |
|
Synched with upstream branch in order to re-run the test to make sure nothing breaks, then PR should be able to merge. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm; I just did a couple of minor style enhancements.
httpjson log handler
|
We'll merge this after #2861 is addressed, which has broken our CI. |
I tested this with ncat and a small config file as
Closes #2850.
Should we implement a test ?