Create regression test for Spark #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the `analytics` module provided by Cray. * Run a simple `pyspark` script to calculate pi.
vkarak
requested changes
May 23, 2018
| from reframe.core.launchers.registry import getlauncher | ||
|
|
||
|
|
||
| class SparkAnalyticsCheck(RunOnlyRegressionTest): |
Contributor
There was a problem hiding this comment.
I suggest using the new-style checks.
| self.valid_prog_environs = ['PrgEnv-cray'] | ||
|
|
||
| self.modules = ['analytics'] | ||
|
|
Contributor
There was a problem hiding this comment.
Remove the blank lines here.
| pi_diff = sn.abs(pi_value - pi_reference) | ||
|
|
||
| self.sanity_patterns = sn.assert_lt(pi_diff, 0.01) | ||
|
|
| pi_reference = math.pi | ||
| pi_diff = sn.abs(pi_value - pi_reference) | ||
|
|
||
| self.sanity_patterns = sn.assert_lt(pi_diff, 0.01) |
Contributor
There was a problem hiding this comment.
If it fits in a single line, you may replace pi_diff with the sn.abs() expression directly.
| self.num_tasks = 72 | ||
| self.num_tasks_per_node = 18 | ||
| super().setup(partition, environ, **job_opts) | ||
| self.job.launcher = getlauncher('local')() |
Contributor
There was a problem hiding this comment.
Put a small comment here, why you need to do that.
| self.num_tasks_per_node = 12 | ||
| else: | ||
| self.num_tasks = 72 | ||
| self.num_tasks_per_node = 18 |
vkarak
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
analyticsmodule provided by Cray.Run a simple
pysparkscript to calculate pi.Closes #107