Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented May 25, 2023

This PR also updates the headers markup to match the Python docs convention.

Closes #2865.

@vkarak vkarak added this to the ReFrame 4.3 milestone May 25, 2023
@vkarak vkarak requested review from ekouts and victorusu May 25, 2023 21:22
@vkarak vkarak self-assigned this May 25, 2023
@vkarak vkarak linked an issue May 25, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a37d89) 86.95% compared to head (3248ba0) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2889   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          60       60           
  Lines       11546    11546           
=======================================
  Hits        10040    10040           
  Misses       1506     1506           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but there is a typo in parameters, it is spelled as paramters...

@vkarak vkarak requested a review from victorusu May 26, 2023 10:55
@vkarak vkarak dismissed victorusu’s stale review May 26, 2023 18:29

Proposed changes have been addressed.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 669e975 into reframe-hpc:master May 26, 2023
@vkarak vkarak deleted the doc/pbs-extra-resources branch May 26, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improving handling of extra resources with PBS scheduler

3 participants