Skip to content

Conversation

@brandonbiggs
Copy link

pdsh and clush are parallel ssh tools. I found the regular ssh launcher to be a bit limiting when trying to run tests on multiple nodes. These launchers add support for additional parallel tools to simplify basic ssh tests on many nodes.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f49b0ec) 86.96% compared to head (9d903c8) 86.97%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2894   +/-   ##
========================================
  Coverage    86.96%   86.97%           
========================================
  Files           60       60           
  Lines        11588    11596    +8     
========================================
+ Hits         10078    10086    +8     
  Misses        1510     1510           
Impacted Files Coverage Δ
reframe/core/backends.py 93.93% <ø> (ø)
reframe/core/launchers/rsh.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also expand the unit tests in test_launchers.py by extending the fixture here and adapt the remaining unit tests.

I could have a look into that.

@vkarak
Copy link
Contributor

vkarak commented Jun 11, 2023

I've added unit tests and moved the definitions of the new launchers in the same file with the ssh launcher, which I renamed to rsh.py for "remote shell launchers". With the minor doc fix above, I think it's ready to go.

@vkarak
Copy link
Contributor

vkarak commented Jun 12, 2023

Lgtm!

@vkarak vkarak changed the title [feat] Added two additional launchers, pdsh and clush [feat] Support for pdsh and clush parallel launchers Jun 12, 2023
@vkarak vkarak merged commit a128328 into reframe-hpc:develop Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants