-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Support for pdsh and clush parallel launchers
#2894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can I test this patch? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2894 +/- ##
========================================
Coverage 86.96% 86.97%
========================================
Files 60 60
Lines 11588 11596 +8
========================================
+ Hits 10078 10086 +8
Misses 1510 1510
☔ View full report in Codecov by Sentry. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also expand the unit tests in test_launchers.py by extending the fixture here and adapt the remaining unit tests.
I could have a look into that.
|
I've added unit tests and moved the definitions of the new launchers in the same file with the |
…f back ticks so the command is properly formatted.
|
Lgtm! |
pdsh and clush parallel launchers
pdsh and clush are parallel ssh tools. I found the regular ssh launcher to be a bit limiting when trying to run tests on multiple nodes. These launchers add support for additional parallel tools to simplify basic ssh tests on many nodes.