Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jun 16, 2023

Closes #2924.

@vkarak vkarak added this to the ReFrame 4.3 milestone Jun 16, 2023
@vkarak vkarak requested review from ekouts, teojgo and victorusu June 16, 2023 13:36
@vkarak vkarak self-assigned this Jun 16, 2023
@vkarak vkarak linked an issue Jun 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b890796) 86.96% compared to head (88e5de4) 86.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2930   +/-   ##
=======================================
  Coverage   86.96%   86.97%           
=======================================
  Files          60       60           
  Lines       11557    11560    +3     
=======================================
+ Hits        10051    10054    +3     
  Misses       1506     1506           
Impacted Files Coverage Δ
reframe/core/config.py 94.60% <100.00%> (+0.01%) ⬆️
reframe/frontend/cli.py 76.95% <100.00%> (ø)
reframe/utility/jsonext.py 86.36% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo teojgo merged commit a653967 into reframe-hpc:master Jun 16, 2023
@vkarak vkarak deleted the bugfix/show-config-crash branch June 16, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

json_formatter in config causes --show-config option to crash

3 participants