[feat] Update default --timestamp format
#2931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
requested changes
Jun 20, 2023
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Probably the change should be made also in test_timestamp_option_default which is the one that failing in the ci.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2931 +/- ##
========================================
Coverage 87.35% 87.35%
========================================
Files 60 60
Lines 11676 11676
========================================
Hits 10199 10199
Misses 1477 1477
☔ View full report in Codecov by Sentry. |
teojgo
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format is
%y%m%dT%H%M%S%zwhich translates to230620T005733+0200.Closes #2867.