Skip to content

[bugfix] Update OAR scheduler backend to accept the Job_Id: syntax #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[bugfix] Update OAR scheduler backend to accept the Job_Id: syntax #2945

wants to merge 3 commits into from

Conversation

@UeliDeSchwert
Copy link
Contributor

@UeliDeSchwert UeliDeSchwert commented Jul 3, 2023

The RegEx now supports id: XXX as well as Job_Id: XXX.

Additionally, the link to the oarstat source is updated.

Fixes #2944

@UeliDeSchwert
Fix reframe-hpc#2944 by adapting the regular expression to allow both…
eadc45f 
… available formats

The RegEx now supports `id: XXX` as well as `Job_Id: XXX`.
Additionally, the link to the oarstat source is updated.
@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Jul 3, 2023

Can I test this patch?

@vkarak vkarak requested review from ekouts and vkarak July 3, 2023 18:22
@vkarak vkarak added this to the ReFrame 4.4 milestone Jul 3, 2023
vkarak
vkarak approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (53ee447) 87.35% compared to head (aaee107) 87.35%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2945   +/-   ##
========================================
  Coverage    87.35%   87.35%           
========================================
  Files           60       60           
  Lines        11676    11676           
========================================
  Hits         10199    10199           
  Misses        1477     1477
Impacted Files Coverage Δ
reframe/core/schedulers/oar.py 39.56% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak changed the title Fix #2944 by adapting the regular expression to allow both available … [bugfix] Update OAR scheduler backend to accept the alternative job id syntax Jul 3, 2023
@vkarak vkarak changed the title [bugfix] Update OAR scheduler backend to accept the alternative job id syntax [bugfix] Update OAR scheduler backend to accept the Job_Id: syntax Jul 3, 2023
@vkarak
Copy link
Contributor

vkarak commented Jul 3, 2023

Since this is a bugfix, it's better to re-open this PR against master so that it makes it to the next patch level release, otherwise it will not be released until 4.4.

@UeliDeSchwert
Copy link
Contributor Author

UeliDeSchwert commented Jul 4, 2023

Superseded by #2946 (PR to master instead of develop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts Awaiting requested review from ekouts

Assignees

@UeliDeSchwert UeliDeSchwert

Labels

bugfix prio: normal schedulers

Projects

ReFrame Backlog
Status: Done

Milestone

ReFrame 4.4

Development

Successfully merging this pull request may close these issues.

When using OAR, depending on the configuration of the oarstat output format, ReFrame might mark tests as finished too early

3 participants

@UeliDeSchwert @jenkins-cscs @vkarak