[testlib] Add ssh_audit test to hpctestlist #2956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test downloads the ssh-audit tool from GitHub and checks if there is any configuration that is considered as a failure. The test is compatible with all the job schedulers. Because it only checks the localhost, where the test script runs. So, it becomes the responsibility of ReFrame to spawn the test script in the desired systems.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2956 +/- ##
========================================
Coverage 87.35% 87.36%
========================================
Files 60 60
Lines 11683 11687 +4
========================================
+ Hits 10206 10210 +4
Misses 1477 1477 ☔ View full report in Codecov by Sentry. |
vkarak
approved these changes
Jul 24, 2023
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Lgtm, just a minor comment.
vkarak
changed the title
Contributor
|
Also, have you checked the docs? Do these tests' docs appear correctly in the lib docs? |
teojgo
requested changes
Aug 8, 2023
Contributor
teojgo
left a comment
teojgo
left a comment
There was a problem hiding this comment.
Add the correspoding heading and reference to the test here: https://github.com/reframe-hpc/reframe/blob/develop/docs/hpctestlib.rst
vkarak
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test downloads the ssh-audit tool from GitHub and checks if there is any configuration that is considered as a failure.
The test is compatible with all the job schedulers. Because it only checks the localhost, where the test script runs. So, it becomes the responsibility of ReFrame to spawn the test script in the desired systems.