[testlib] Add fs mount options check to hpctstlib #2958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filesystem_option_check check if the file systems were properly configured based on their type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2958 +/- ##
========================================
Coverage 86.70% 86.70%
========================================
Files 61 61
Lines 11996 11996
========================================
Hits 10401 10401
Misses 1595 1595 ☔ View full report in Codecov by Sentry. |
vkarak
requested changes
Jul 24, 2023
vkarak
changed the title
This newer version of test is not parameterised. This implies that one should see a single test that processes all filesystems. This version also adds to the output the reference options used by the test.
|
Hello @victorusu, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2023-10-23 21:45:43 UTC |
vkarak
requested changes
Oct 20, 2023
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Some minor style suggestions.
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
vkarak
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filesystem_option_check check if the file systems were properly configured based on their type