Skip to content

[bugfix] Respect execution order of overriden hooks #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2023
Merged

[bugfix] Respect execution order of overriden hooks #2997

merged 3 commits into from
Sep 21, 2023

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 15, 2023

Closes #2800.

@vkarak vkarak added this to the ReFrame 4.4 milestone Sep 15, 2023
@vkarak vkarak self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (3abb7e7) 87.27% compared to head (4f67cbe) 87.28%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2997      +/-   ##
==========================================
+ Coverage   87.27%   87.28%   +0.01%     
==========================================
  Files          60       60              
  Lines       11697    11707      +10     
==========================================
+ Hits        10209    10219      +10     
  Misses       1488     1488
Files Changed Coverage Δ
reframe/core/hooks.py 91.17% <100.00%> (+0.95%) ⬆️
reframe/core/meta.py 99.12% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak linked an issue Sep 21, 2023 that may be closed by this pull request
Do not change the order of execution of a base class hook when overriding it #2800
Closed
victorusu
victorusu approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 2d6ae43 into reframe-hpc:master Sep 21, 2023
@vkarak vkarak deleted the bugfix/overriden-hooks-exec-order branch September 21, 2023 23:14
@vkarak vkarak mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorusu victorusu victorusu approved these changes

@ekouts ekouts Awaiting requested review from ekouts

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@vkarak vkarak

Labels

bugfix prio: normal test syntax

Projects

ReFrame Backlog
Status: Done

Milestone

ReFrame 4.4

Development

Successfully merging this pull request may close these issues.

Do not change the order of execution of a base class hook when overriding it

2 participants

@vkarak @victorusu