[bugfix] Detect missing curl in bootstrap.sh
#3096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can I test this patch? |
Contributor
Author
|
Yes. To test locally, I used a default Ubuntu 22.04 server, cloned the repo and ran bootstrap, installed curl, the re-ran bootstrap. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3096 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 61 61
Lines 12041 12041
=======================================
Hits 10432 10432
Misses 1609 1609 ☔ View full report in Codecov by Sentry. |
When curl is missing, as is the default on Ubuntu, we blow right past the curl failure and try to run commands. Clean this up just a tad by detecting a missing curl command.
Contributor
|
@tmjbios Thanks for the fix. I updated your PR to be against master as it's a bug fix and we could release it in the next patch release. |
vkarak
changed the title
curl in bootstrap.sh
vkarak
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl is not a default package on most Linux distributions, and is not listed as a requirement for reFrame.
When curl is missing, bootstrap.sh will blow right past the curl failure and continue to attempt to execute commands.
Add a check for curl, and print a meaningful message + exit if it is not found.