[feat] Add nvcc as an environment configuration parameter
#3098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows you to specify the path to nvidia's nvcc a part of a system environment. This allows for multiple environments with different paths to nvcc without the use of modules or the PATH environment. It allows for nvcc being unset in the environment and will default to 'nvcc'.
Collaborator
|
Can I test this patch? |
teojgo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3098 +/- ##
========================================
Coverage 86.63% 86.63%
========================================
Files 61 61
Lines 12041 12042 +1
========================================
+ Hits 10432 10433 +1
Misses 1609 1609 ☔ View full report in Codecov by Sentry. |
vkarak
changed the title
nvcc as an environment configuration parameter
vkarak
approved these changes
Jan 30, 2024
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Thanks for the PR! Lgtm. Just a minor comment.
vkarak
requested changes
Jan 30, 2024
vkarak
approved these changes
Jan 30, 2024
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I updated the PR with the suggested changes, lgtm now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows you to specify the path to nvidia's nvcc a part of a system environment. This allows for multiple environments with different paths to nvcc without the use of modules or the PATH environment. It allows for nvcc being unset in the environment and will default to 'nvcc'.