[bugfix] Fix logging crash when the check_#ALL placeholder is used
#3142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this subtle and nasty bug while working on the new tutorial. It is exposed more easily now that the variables and parameters are by default loggable. The problem is the following:
When a series of tests that define different variables is set, ReFrame's logging will crash with an error like this:
The problem was that the message's format was calculated once from the
check_#ALLspecial placeholder, so when trying to format the message from another test with different variables, it would cause this crash. I have added a unit test that reproduces this error exactly.This PR fixes this problem by keeping the expanded format strings for each test. Also, it fixes a similar problem that was causing ReFrame to generate wrong perflog headers for subsequent tests.