Skip to content

[bugfix] Hide disabled hooks from --describe option's output #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[bugfix] Hide disabled hooks from --describe option's output #3153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ def disable_hook(self, hook_name):
'''
self._disabled_hooks.add(hook_name)

@property
def disabled_hooks(self):
return self._disabled_hooks

@classmethod
def pipeline_hooks(cls):
ret = {}
Expand Down
5 changes: 3 additions & 2 deletions reframe/frontend/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,9 @@ def describe_checks(testcases, printer):
rec['variant_num'] = tc.check.variant_num
for stage, hooks in tc.check.pipeline_hooks().items():
for hk in hooks:
rec['pipeline_hooks'].setdefault(stage, [])
rec['pipeline_hooks'][stage].append(hk.__name__)
if hk.__name__ not in tc.check.disabled_hooks:
rec['pipeline_hooks'].setdefault(stage, [])
rec['pipeline_hooks'][stage].append(hk.__name__)

for attr in list(rec.keys()):
if attr == '__rfm_class__':
Expand Down