[feat] Allow ReFrame to pass the access options in command line instead of the script for Slurm

[ekouts]

Right now I am only changing this for Slurm. I leave these options in the slurm script, mostly to remind whoever might be checking the script that the options are not ignored. Do you think I should remove them from the script?

Closes #2970 .

[pep8speaks]

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-06-13 21:32:06 UTC

[vkarak]

I would suggest to (a) extend this to all the schedulers and (b) do not emit the options in the job script.

Also I don't know how would be able to test this fully, but at least we need unit tests that set this option and verify that the sched_access options are not passed in the script if this configuration option is set.

[codecov]

Codecov Report

Attention: Patch coverage is 47.61905% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (6f6aba0) to head (f084223).
Report is 67 commits behind head on develop.

❗ Current head f084223 differs from pull request most recent head e79279a

Please upload reports for the commit e79279a to get more accurate results.

Files	Patch %	Lines
reframe/core/schedulers/lsf.py	33.33%	6 Missing ⚠️
reframe/core/schedulers/pbs.py	40.00%	6 Missing ⚠️
reframe/core/schedulers/oar.py	44.44%	5 Missing ⚠️
reframe/core/schedulers/slurm.py	61.53%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3156      +/-   ##
===========================================
- Coverage    86.67%   86.56%   -0.12%     
===========================================
  Files           61       61              
  Lines        12143    12167      +24     
===========================================
+ Hits         10525    10532       +7     
- Misses        1618     1635      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.