[bugfix] Treat OR Slurm constraints in flexible node allocation #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
approved these changes
Apr 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3158 +/- ##
===========================================
+ Coverage 86.65% 86.66% +0.01%
===========================================
Files 61 61
Lines 12121 12134 +13
===========================================
+ Hits 10503 10516 +13
Misses 1618 1618 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I would still need to add a unit test to check the behaviour with an invalid expression. |
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-04-15 16:55:58 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes also the way
sched_accessconstraints are combined with those specified in the CLI or in thejob.optionsby parenthesizing appropriately. It also updates the docs.