Fix CUDA DDT check after upgrade to CUDA 9 #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 91.18% 91.21% +0.02%
==========================================
Files 67 67
Lines 7941 7941
==========================================
+ Hits 7241 7243 +2
+ Misses 700 698 -2
Continue to review full report at Codecov.
|
vkarak
changed the title
vkarak
approved these changes
Jun 14, 2018
teojgo
approved these changes
Jun 14, 2018
| } | ||
| self.maintainers = ['MK', 'JG'] | ||
| self.tags = {'production'} | ||
| self.post_run = ['ddt -V ; which ddt ;'] |
Contributor
There was a problem hiding this comment.
Is this line needed just for checking or can we put another sanity check for this?
Contributor
Author
|
Is this line needed just for checking or can we put another sanity check
for this?
a sanity check is probably too much but this line will help next time it will
fail.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328.