Skip to content

[test] Update PrgEnv-pgi definitions on Kesch #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2018
Merged

[test] Update PrgEnv-pgi definitions on Kesch #348

merged 4 commits into from
Jul 10, 2018

Conversation

@ajocksch
Copy link
Contributor

@ajocksch ajocksch commented Jul 6, 2018 •
edited by vkarak
Loading

Also remove workaround in gpu_direct_acc.py.

@ajocksch ajocksch self-assigned this Jul 6, 2018
@ajocksch ajocksch requested a review from teojgo July 6, 2018 07:08
@ajocksch ajocksch mentioned this pull request Jul 6, 2018
Merged
@vkarak
Copy link
Contributor

vkarak commented Jul 6, 2018

Please tag accordingly and put this PR in the right project and milestone.

@vkarak vkarak changed the title updated prgenv-pgi; deleted workaround in gpu_direct_acc.py Update PrgEnv-pgi definitions on Kesch Jul 6, 2018
@vkarak vkarak self-requested a review July 6, 2018 08:12
@vkarak vkarak added this to the ReFrame sprint 2018w26 milestone Jul 6, 2018
vkarak
vkarak approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just fix the conflicts with the master.

@vkarak
Copy link
Contributor

vkarak commented Jul 6, 2018

@teojgo @ajocksch I think CI on Kesch is expected to fail for the default PrgEnv-pgi.

teojgo
teojgo approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PrgEnv-pgi failure is expected, lgtm after the conflicts are resolved.

@vkarak
Copy link
Contributor

vkarak commented Jul 10, 2018

@teojgo Can you fix the conflicts? This is ready to be merged otherwise.

@codecov-io
Copy link

codecov-io commented Jul 10, 2018 •
edited
Loading

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files          68       68           
  Lines        8244     8244           
=======================================
  Hits         7510     7510           
  Misses        734      734

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33a074...453f063. Read the comment docs.

vkarak
vkarak requested changes Jul 10, 2018
View reviewed changes
cscs-checks/prgenv/gpu_direct_acc.py Outdated
'MPICH_RDMA_ENABLED_CUDA': '1',
'MV2_USE_CUDA': '1',
'G2G': '1'
'G2G': '1',
Copy link
Contributor

@vkarak vkarak Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teojgo This does not fix the conflict; it breaks the code... I am fixing it now. You should not rely entirely on the CI to catch errors in user tests, especially after merges.

@vkarak vkarak changed the title Update PrgEnv-pgi definitions on Kesch [test] Update PrgEnv-pgi definitions on Kesch Jul 10, 2018
@vkarak vkarak merged commit 42d6344 into master Jul 10, 2018
@vkarak vkarak deleted the kesch/allprgenv branch July 10, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo teojgo approved these changes

Assignees

@ajocksch ajocksch

@teojgo teojgo

Labels

prio: important request for enhancement

Projects

None yet

Milestone

ReFrame sprint 2018w26

Development

Successfully merging this pull request may close these issues.

5 participants

@ajocksch @vkarak @codecov-io @teojgo