Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 10, 2018

The current dummy server and port produce errors when trying to log the
performance. For this reason, the corresponding configuration lines are
commented out specially using the #@ prefix and will be patched
on-the-fly for production runs.

This must be merged asap, cos it's blocking other PRs.

Fixes #349.

The current dummy server and port produce errors when trying to log the
performance. For this reason, the corresponding configuration lines are
commented out specially using the `#@` prefix and will be patched
on-the-fly for production runs.
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title Comment out Graylog handler from CSCS config [bugfix] Comment out Graylog handler from CSCS config Jul 10, 2018
@vkarak vkarak added the bugfix label Jul 10, 2018
@codecov-io
Copy link

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files          68       68           
  Lines        8244     8244           
=======================================
  Hits         7510     7510           
  Misses        734      734

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba6d2f...ea1fa19. Read the comment docs.

@vkarak vkarak merged commit 2018a71 into reframe-hpc:master Jul 10, 2018
@vkarak vkarak deleted the bugfix/cscs-config branch July 10, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Os Error when trying to perform the performance logging

3 participants