[ci] Check added/modified regression tests w.r.t master #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Find the added/modified regression tests based on diversion from the master branch.
vkarak
requested changes
Jul 11, 2018
| tutorialchecks=( $(git log --name-status --oneline --no-merges -1 | \ | ||
| awk '/^[AM]/ { print $2 } /^R0[0-9][0-9]/ { print $3 }' | \ | ||
| grep -e '^tutorial/(?!config/).*\.py') ) | ||
| tutorialchecks=( $(git diff origin/master...HEAD --name-only --oneline --no-merges | \ |
Contributor
There was a problem hiding this comment.
Why are you using three dots here instead of two. If there's no difference, I prefer ...
Contributor
Author
There was a problem hiding this comment.
The three dots are different from two. The ... checks diversion from the latest common point while the .. checks without taking the common point into account. Thus, ... is better because there could be a change in the master in the meanwhile.That was one of the problems we had in the production where .. was initially used.
vkarak
approved these changes
Jul 11, 2018
Contributor
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the master branch.