[test] Adapt helloworld tests to build systems #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt to new test syntax. * Reformat to be consistent with the coding style of ReFrame.
vkarak
requested changes
Aug 23, 2018
cscs-checks/prgenv/helloworld.py
Outdated
| self.num_cpus_per_task = 1 | ||
|
|
||
|
|
||
| @rfm.parameterized_test(*[[lang, linkage] for lang in ['cpp', 'c', 'f90'] |
Contributor
There was a problem hiding this comment.
I would put this for on the next line for symmetry.
added 2 commits
August 24, 2018 08:54
vkarak
requested changes
Aug 30, 2018
cscs-checks/prgenv/helloworld.py
Outdated
|
|
||
| class HelloWorldBaseTest(rfm.RegressionTest): | ||
| def __init__(self, name, lang, linkage, **kwargs): | ||
| def __init__(self, name, lang, linkage): |
Contributor
There was a problem hiding this comment.
I think variant should be a better name for name here, shouldn't it?
vkarak
approved these changes
Aug 31, 2018
Contributor
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to new test syntax.
Reformat to be consistent with the coding style of ReFrame.
Fixes #395