[test] Adapt dgemm test to use build systems #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt dgemm test to use the build systems future. * Adapt dgemm to the new syntax.
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
======================================
Coverage 91.2% 91.2%
======================================
Files 70 70
Lines 8582 8582
======================================
Hits 7827 7827
Misses 755 755Continue to review full report at Codecov.
|
vkarak
requested changes
Aug 9, 2018
cscs-checks/libraries/math/dgemm.py
Outdated
| def __init__(self): | ||
| self.cflags = ['-O3', '-I$EBROOTOPENBLAS/include'] | ||
| self.ldflags = ['-L$EBROOTOPENBLAS/lib', '-lopenblas', '-lpthread', | ||
| '-lgfortran'] |
Contributor
There was a problem hiding this comment.
Why don't you set directly the corresponding flags from the build system?
cscs-checks/libraries/math/dgemm.py
Outdated
| self.ldflags = None | ||
| self.build_system = 'SingleSource' | ||
| self.build_system.cflags = self.cflags | ||
| self.build_system.ldflags = self.ldflags |
Contributor
There was a problem hiding this comment.
I don't like this design. The subclasses should set directly the flags the need.
vkarak
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt dgemm test to use the build systems future.
Adapt dgemm to the new syntax.
Fixes #383