[test] Adapt stream microbenchmark test to build systems #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt the stream microbenchmark regression test to use build systems. * Use the new regression test syntax.
teojgo
changed the title
vkarak
requested changes
Aug 16, 2018
| self.current_environ.variables['OMP_NUM_THREADS'] = \ | ||
| str(self.num_cpus_per_task) | ||
| self.current_environ.variables['OMP_NUM_THREADS'] = str( | ||
| self.num_cpus_per_task) |
Contributor
There was a problem hiding this comment.
I don't like setting the variables attribute of the current environment directly. Besides, I don't think that they will be loaded. You should set self.variables instead and call super().setup(...) later.
Contributor
There was a problem hiding this comment.
Same applies for the OMP_PROC_BIND.
Contributor
There was a problem hiding this comment.
Everything fits in a single line here.
vkarak
requested changes
Aug 23, 2018
| self.current_environ.variables['OMP_NUM_THREADS'] = \ | ||
| str(self.num_cpus_per_task) | ||
| self.current_environ.variables['OMP_NUM_THREADS'] = str( | ||
| self.num_cpus_per_task) |
Contributor
There was a problem hiding this comment.
Everything fits in a single line here.
vkarak
approved these changes
Aug 23, 2018
Contributor
|
@teojgo The failure on Kesch is expected. I will merge this one. |
Contributor
|
@jenkins-cscs retry daint dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the stream microbenchmark regression test to
use build systems.
Use the new regression test syntax.
Closes #391