[test] Adapt cdo test to PE 18.07 #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt to new regression test syntax.
vkarak
requested changes
Aug 28, 2018
cscs-checks/tools/io/cdo.py
Outdated
| class CDOBaseCheck(rfm.RunOnlyRegressionTest): | ||
| def __init__(self, sub_check): | ||
| super().__init__() | ||
| self.name = 'CDO_' + sub_check + '_check' |
Contributor
There was a problem hiding this comment.
I think the default naming convention should be enough.
Contributor
There was a problem hiding this comment.
So you may not even pass the sub_check argument.
Contributor
|
@jenkins-cscs retry dom |
vkarak
approved these changes
Aug 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=========================================
- Coverage 91.22% 91.2% -0.03%
=========================================
Files 70 70
Lines 8585 8585
=========================================
- Hits 7832 7830 -2
- Misses 753 755 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #370