[test] Adapt netcdf tests to build systems #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 91.2% 91.24% +0.03%
==========================================
Files 70 70
Lines 8585 8585
==========================================
+ Hits 7830 7833 +3
+ Misses 755 752 -3
Continue to review full report at Codecov.
|
vkarak
requested changes
Aug 31, 2018
| def setup(self, partition, environ, **job_opts): | ||
| # NOTE: Workaround to fix static linking for C++ with PrgEnv-pgi | ||
| if (environ.name == 'PrgEnv-pgi' and self.lang == 'cpp' | ||
| and self.linkage == 'static'): |
Contributor
There was a problem hiding this comment.
Put every operand of and on a separate line and and should be placed at the end of line.
vkarak
approved these changes
Sep 1, 2018
Contributor
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387
Closes #365