Skip to content

[test] Adapt GpuBandwidthTest to build_systems #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2018
Merged

[test] Adapt GpuBandwidthTest to build_systems #438

merged 5 commits into from
Sep 6, 2018

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Sep 4, 2018 •
edited
Loading

Solves the error during compilation, caused by not including the current dir to path so that the header files are found.

@teojgo teojgo self-assigned this Sep 4, 2018
@teojgo teojgo requested a review from vkarak September 4, 2018 08:05
@vkarak vkarak added this to the ReFrame sprint 2018w35 milestone Sep 4, 2018
vkarak
vkarak approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo
Copy link
Contributor Author

teojgo commented Sep 4, 2018 •
edited
Loading

@jenkins-cscs retry all

@codecov-io
Copy link

codecov-io commented Sep 6, 2018 •
edited
Loading

Codecov Report

Merging #438 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.03%     
==========================================
  Files          70       70              
  Lines        8611     8611              
==========================================
- Hits         7858     7856       -2     
- Misses        753      755       +2
Impacted Files Coverage Δ
reframe/core/config.py 82.72% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e26e8c...fe31d9d. Read the comment docs.

@vkarak vkarak merged commit e792fd3 into reframe-hpc:master Sep 6, 2018
@teojgo teojgo deleted the regresstion_test/gpu_bandwidth_build_systems branch September 6, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@teojgo teojgo

Labels

prio: important request for enhancement

Projects

None yet

Milestone

ReFrame sprint 2018w35

Development

Successfully merging this pull request may close these issues.

3 participants

@teojgo @codecov-io @vkarak