[test] Adapt perftools to use build systems #439
Conversation
* Adapt the perftools test to use build systems. * Use new regression test syntax.
| self.valid_prog_environs = ['PrgEnv-cray', 'PrgEnv-gnu'] | ||
|
|
||
| # NOTE: Reduce time limit because for PrgEnv-pgi even if the output | ||
| # is correct, the batch job uses all the time. |
There was a problem hiding this comment.
Should we open a ticket to ops for that?
There was a problem hiding this comment.
@jgphpc also suggested earlier today to open a ticket. (yet, I could imagine he meant the tools-rt and not immediately ops)
| def setup(self, environ, partition, **job_opts): | ||
| super().setup(environ, partition, **job_opts) | ||
| flags = self.prgenv_flags[self.current_environ.name] | ||
| flags += ['-g', '-D_CSCS_ITMAX=1', '-DUSE_MPI'] |
There was a problem hiding this comment.
I would use the build_system.cppflags for the -D definitions and as for the -g, I would put it in each entry in the prgenv_flags dictionary. This way, you will have all the compilation flags in a single place in the __init__().
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
======================================
Coverage 91.2% 91.2%
======================================
Files 70 70
Lines 8611 8611
======================================
Hits 7854 7854
Misses 757 757Continue to review full report at Codecov.
|
4 participants
Adapt the perftools test to use build systems.
Use new regression test syntax.
Solves the test failure due to the following error:
attempt to set an aggregate field of different type. Required typespec: list[str]This is the last regression test that addresses issue #397.
Closes #397