Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 8, 2018

Also:

  • The logdir system config attribute is deprecated and replaced by the
    perflogdir.

  • Documentation needs to be updated.

Fixes #419.

Also:
- The `logdir` system config attribute is deprecated and replaced by the
  `perflogdir`.
@vkarak vkarak added this to the ReFrame sprint 2018w35 milestone Sep 8, 2018
@vkarak vkarak self-assigned this Sep 8, 2018
@vkarak vkarak requested review from teojgo and victorusu September 8, 2018 22:08
@vkarak vkarak changed the title [bugfix] Fix reading of 'logdir' setting from system config [wip] [bugfix] Fix reading of 'logdir' setting from system config Sep 8, 2018
@codecov-io
Copy link

codecov-io commented Sep 8, 2018

Codecov Report

Merging #445 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   91.23%   91.23%   +<.01%     
==========================================
  Files          70       70              
  Lines        8611     8625      +14     
==========================================
+ Hits         7856     7869      +13     
- Misses        755      756       +1
Impacted Files Coverage Δ
unittests/resources/settings.py 100% <ø> (ø) ⬆️
reframe/core/systems.py 85% <100%> (ø) ⬆️
unittests/test_config.py 97.53% <100%> (+0.09%) ⬆️
reframe/frontend/cli.py 78.43% <100%> (+0.39%) ⬆️
unittests/test_runtime.py 100% <100%> (ø) ⬆️
reframe/core/config.py 82.45% <66.66%> (-0.28%) ⬇️
reframe/core/runtime.py 87.09% <85.71%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e792fd3...447bc05. Read the comment docs.

@vkarak vkarak changed the title [wip] [bugfix] Fix reading of 'logdir' setting from system config [bugfix] Fix reading of 'logdir' setting from system config Sep 9, 2018
@vkarak vkarak merged commit 3cf1113 into reframe-hpc:master Sep 10, 2018
@vkarak vkarak deleted the bugfix/config-logdir branch September 10, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants