[test] Increase GROMACS sanity check tolerance to 0.1% #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with eth-cscs:master
vkarak
requested changes
Sep 14, 2018
| self.sanity_patterns = sn.all([ | ||
| sn.assert_found('Finished mdrun', output_file), | ||
| sn.assert_lt(energy_diff, 1560.1) | ||
| sn.assert_lt(energy_diff, 3271) |
Contributor
There was a problem hiding this comment.
Since we are now talking about percentages, wouldn't it make better sense to use assert_reference here?
Contributor
|
@victorusu Is the PR title correct? I had the impression the old threshold was at 0.05%. |
victorusu
changed the title
victorusu
force-pushed
the
victorusu-gromacs-increase-sanity-tolerance
branch
from
47c1f86 to
e980ddd
Compare
vkarak
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.