Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 20, 2018

This PR changes basically the Job class by changing the default time limit.

  • Time limit now defaults to None, meaning that the backends should
    not impose any time limit on the running job.
  • Build jobs do not have any time limit.

Fixes #465.

- Time limit now defaults to `None`, meaning that the backends should
  not impose any time limit on the running job.
- Build jobs do not have any time limit.
@vkarak vkarak added this to the ReFrame sprint 2018w39 milestone Sep 20, 2018
@vkarak vkarak self-assigned this Sep 20, 2018
@vkarak vkarak requested a review from teojgo September 20, 2018 15:50
@vkarak vkarak changed the title Change default time limit of the Job objects [bugfix] Remove time limit from build jobs Sep 20, 2018
@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #474 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   91.36%   91.37%   +<.01%     
==========================================
  Files          70       70              
  Lines        8790     8796       +6     
==========================================
+ Hits         8031     8037       +6     
  Misses        759      759
Impacted Files Coverage Δ
unittests/test_launchers.py 93.9% <ø> (ø) ⬆️
reframe/core/schedulers/__init__.py 94.69% <ø> (ø) ⬆️
reframe/core/schedulers/slurm.py 57.89% <100%> (+0.37%) ⬆️
reframe/core/pipeline.py 91.68% <100%> (ø) ⬆️
reframe/core/schedulers/local.py 100% <100%> (ø) ⬆️
reframe/core/schedulers/pbs.py 66.25% <100%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1294eeb...bac4eed. Read the comment docs.

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo
Copy link
Contributor

teojgo commented Sep 26, 2018

@jenkins-cscs retry all

@vkarak vkarak merged commit 5d3980b into reframe-hpc:master Sep 27, 2018
@vkarak vkarak deleted the bugfix/compilation-time-limit branch September 27, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants