[test] Adapt Kesch tests to final CSCS prog. environments #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds several minor improvements to the tests, such as transition to new style, module fixes, coding style fixes etc.
vkarak
changed the title
This is directory is `cscs-checks/mch`.
vkarak
changed the title
vkarak
commented
Sep 26, 2018
Contributor
Author
|
@victorusu @ajocksch When reviewing this PR, please make sure to double check whether we need all the tested combinations or whether we need to test more. For summary, check this list. |
vkarak
commented
Sep 26, 2018
cscs-checks/cuda/multi_gpu.py
Outdated
| self.tags = {'production'} | ||
|
|
||
| def setup(self, partition, environ, **job_opts): | ||
| def _setup(self, partition, environ, **job_opts): |
Contributor
Author
There was a problem hiding this comment.
This one, I should remove it.
Contributor
Author
|
@eth-cscs/reframe-devteam Hey guys, can somebody review this PR? |
victorusu
approved these changes
Oct 1, 2018
Contributor
victorusu
left a comment
victorusu
left a comment
There was a problem hiding this comment.
I just have a few comments. Nothing that would hinder the merge.
kraushm
reviewed
Oct 2, 2018
Contributor
kraushm
left a comment
kraushm
left a comment
There was a problem hiding this comment.
Since the system has been taken down completely, I don't really see a reason to keep anything related to Monch in the tests.
Contributor
Author
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds several minor improvements to the tests, such as
transition to new style, module fixes, coding style fixes etc.
Fixes #398.
For test failures on Kesch, see here for explanations.
Still todo: