Skip to content

[bugfix] Fix retry report when test fails before the setup phase #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2018
Merged

[bugfix] Fix retry report when test fails before the setup phase #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6bd26a
Adaptation of retry report
omlins Oct 22, 2018
fd63bc9
Add unittest
omlins Oct 24, 2018
76aad0f
minor change
omlins Oct 24, 2018
cbae966
merging the bad test unittests
omlins Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions reframe/frontend/statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,18 @@ def retry_report(self):
report.append('SUMMARY OF RETRIES')
report.append(line_width * '-')
messages = {}

for run in range(1, len(self._tasks)):
for t in self.get_tasks(run):
key = '%s:%s:%s' % (
t.check.name, t.check.current_partition.fullname,
t.check.current_environ.name
)
partition_name = ''
environ_name = ''
if t.check.current_partition:
partition_name = t.check.current_partition.fullname

if t.check.current_environ:
environ_name = t.check.current_environ.name

key = '%s:%s:%s' % (t.check.name, partition_name, environ_name)
# Overwrite entry from previous run if available
messages[key] = (
' * Test %s was retried %s time(s) and %s.' %
Expand Down
13 changes: 8 additions & 5 deletions unittests/test_policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import unittests.fixtures as fixtures
from unittests.resources.checks.hellocheck import HelloTest
from unittests.resources.checks.frontend_checks import (
KeyboardInterruptCheck, SleepCheck, SleepCheckPollFail,
SleepCheckPollFailLate, BadSetupCheck, RetriesCheck, SystemExitCheck)
KeyboardInterruptCheck, SystemExitCheck, SleepCheck, SleepCheckPollFail,
SleepCheckPollFailLate, BadSetupCheck, BadSetupCheckEarly, RetriesCheck)


class TestSerialExecutionPolicy(unittest.TestCase):
Expand Down Expand Up @@ -138,14 +138,17 @@ def test_system_exit_within_test(self):

def test_retries_bad_check(self):
max_retries = 2
checks = [BadSetupCheck()]
checks = [BadSetupCheck(), BadSetupCheckEarly()]
self.runner._max_retries = max_retries
self.runner.runall(checks)

# Ensure that the test was retried #max_retries times and failed.
self.assertEqual(1, self.runner.stats.num_cases())
self.assertEqual(2, self.runner.stats.num_cases())
self.assertEqual(max_retries, rt.runtime().current_run)
self.assertEqual(1, self.runner.stats.num_failures())
self.assertEqual(2, self.runner.stats.num_failures())

# Ensure that the report does not raise any exception.
self.runner.stats.retry_report()

def test_retries_good_check(self):
max_retries = 2
Expand Down