-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Update retries stage/output directory naming convention #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Update retries stage/output directory naming convention #580
Conversation
|
@jenkins-cscs retry daint |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it works fine.
- The suffix is added by the `HostResources`. - `run_suffix()` was replaced by the more generic `_format_dirs()` function. - The suffix for the retries directories is now `@N`.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omlins I fixed the PR myself. Please have a look at the changes.
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 91.59% 91.55% -0.04%
==========================================
Files 72 72
Lines 8954 8962 +8
==========================================
+ Hits 8201 8205 +4
- Misses 753 757 +4
Continue to review full report at Codecov.
|
|
Thanks @vkarak for the improvement. I changed the test-directory suffix back to the form |
Modifies the behaviour of ReFrame to create stage and output folders as in the following example:
Closes #536.