Skip to content

Conversation

@omlins
Copy link
Contributor

@omlins omlins commented Nov 13, 2018

Modifies the behaviour of ReFrame to create stage and output folders as in the following example:

/path/to/stage/sys/part/env/testname
/path/to/stage/sys/part/env/testname_retry1
/path/to/stage/sys/part/env/testname_retry2

Closes #536.

@omlins omlins added this to the ReFrame sprint 2018w44 milestone Nov 13, 2018
@omlins omlins self-assigned this Nov 13, 2018
@omlins omlins requested a review from vkarak November 13, 2018 11:37
@vkarak vkarak requested a review from teojgo November 13, 2018 17:07
@vkarak
Copy link
Contributor

vkarak commented Nov 13, 2018

@jenkins-cscs retry daint

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works fine.

@vkarak vkarak changed the title [feat] Modification of the retries-directories [feat] Update retries stage directory naming convention Nov 14, 2018
- The suffix is added by the `HostResources`.
- `run_suffix()` was replaced by the more generic `_format_dirs()` function.
- The suffix for the retries directories is now `@N`.
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omlins I fixed the PR myself. Please have a look at the changes.

@codecov-io
Copy link

Codecov Report

Merging #580 into master will decrease coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   91.59%   91.55%   -0.04%     
==========================================
  Files          72       72              
  Lines        8954     8962       +8     
==========================================
+ Hits         8201     8205       +4     
- Misses        753      757       +4
Impacted Files Coverage Δ
reframe/core/pipeline.py 91.72% <100%> (+0.02%) ⬆️
reframe/core/runtime.py 87.05% <86.66%> (-0.83%) ⬇️
reframe/core/config.py 82.6% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cd5ac...617295a. Read the comment docs.

@omlins
Copy link
Contributor Author

omlins commented Nov 19, 2018

Thanks @vkarak for the improvement. I changed the test-directory suffix back to the form _retry1 as agreed in the stand-up meeting. I believe the MR is ready for merging.

@omlins omlins changed the title [feat] Update retries stage directory naming convention [feat] Update retries stage/output directory naming convention Nov 19, 2018
@vkarak vkarak merged commit 3839bcd into reframe-hpc:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants