Skip to content

[test] Add specific tag for MCH tests #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2018
Merged

[test] Add specific tag for MCH tests #594

merged 5 commits into from
Dec 3, 2018

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 21, 2018

Also:

  • Remove kesch:cn from CDO/NCO tests

Add specific tag for MCH tests
bbb0fe4 
Also:

  - Remove `kesch:cn` from CDO/NCO tests
@vkarak vkarak added this to the Upcoming sprint milestone Nov 21, 2018
@vkarak vkarak self-assigned this Nov 21, 2018
@vkarak vkarak requested review from ajocksch, omlins and teojgo November 21, 2018 22:26
@vkarak
Copy link
Contributor Author

vkarak commented Nov 22, 2018

@jenkins-cscs retry all

@vkarak
Copy link
Contributor Author

vkarak commented Nov 23, 2018

@ajocksch @omlins @teojgo Can sb review this? The idea is to easily select MCH tests.

ajocksch
ajocksch suggested changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@ajocksch ajocksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise it looks all right

omlins
omlins suggested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@omlins omlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, except for the point that @ajocksch raised. Moreover, it would be good to clarify if the 'kesh:cn' tests should really be removed.

@vkarak
Copy link
Contributor Author

vkarak commented Dec 1, 2018

@ajocksch Can you please approve this so that we can merge it?

@vkarak
Copy link
Contributor Author

vkarak commented Dec 3, 2018

@jenkins-cscs retry kesch

@codecov-io
Copy link

codecov-io commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          72       72           
  Lines        8992     8992           
=======================================
  Hits         8231     8231           
  Misses        761      761

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e870f99...dd69d5c. Read the comment docs.

@vkarak vkarak merged commit cb47046 into reframe-hpc:master Dec 3, 2018
@vkarak vkarak deleted the check/tag-mch-tests branch December 3, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teojgo teojgo Awaiting requested review from teojgo

2 more reviewers

@ajocksch ajocksch ajocksch approved these changes

@omlins omlins omlins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vkarak vkarak

Labels

prio: important

Projects

None yet

Milestone

ReFrame sprint 2018w48

Development

Successfully merging this pull request may close these issues.

4 participants

@vkarak @codecov-io @ajocksch @omlins