Skip to content

[test] Add test for gdb4hpc #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 9, 2019
Merged

[test] Add test for gdb4hpc #603

merged 16 commits into from
Apr 9, 2019

Conversation

@jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Nov 27, 2018 •
edited by teojgo
Loading

Fixes #601
Fixes #521

Feedback needed.
Using daint:gpu will probably look equally ugly (running 2 jobs ?).

@jgphpc
Copy link
Contributor Author

jgphpc commented Nov 27, 2018

@vkarak ok ?

@jgphpc jgphpc changed the title WIP: gdb4hpc WIP [test] gdb4hpc Nov 27, 2018
@victorusu victorusu self-assigned this Nov 27, 2018
@victorusu victorusu assigned jgphpc and unassigned victorusu Nov 27, 2018
@victorusu victorusu requested a review from teojgo November 27, 2018 16:25
@vkarak vkarak changed the title WIP [test] gdb4hpc WIP [test] Add test for gdb4hpc Nov 27, 2018
victorusu
victorusu requested changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jg, this is a very interesting use case for ReFrame. I have just a few questions regarding the workflow.

jgphpc and others added 2 commits November 27, 2018 18:52
vkarak
vkarak requested changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, except for some enhancements. I also don't understand the purpose of the .slm file. See my comments there.

@vkarak
Copy link
Contributor

vkarak commented Mar 9, 2019

@jgphpc Is this still a WIP?

@jgphpc
Copy link
Contributor Author

jgphpc commented Mar 22, 2019

Need to add this

gdbmode
printf \"hello\n\"
printf "%d", 0
end
list

@vkarak vkarak added this to the Upcoming sprint milestone Mar 27, 2019
victorusu
victorusu approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title WIP [test] Add test for gdb4hpc [test] Add test for gdb4hpc Apr 5, 2019
vkarak
vkarak requested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only minor comments. This is a very strange to support inside ReFrame. Can you open a separate issue explaining in more details the test case and also point to this PR?

vkarak
vkarak approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except of a couple of minor things.

@vkarak
Copy link
Contributor

vkarak commented Apr 9, 2019

@jenkins-cscs retry daint

@vkarak
Copy link
Contributor

vkarak commented Apr 9, 2019

@jgphpc This test fails on Daint. Can you check in order to merge it?

@pep8speaks
Copy link

pep8speaks commented Apr 9, 2019 •
edited
Loading

Hello @jgphpc, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2019-04-09 15:32:37 UTC

@codecov-io
Copy link

codecov-io commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          76       76           
  Lines        9501     9501           
=======================================
  Hits         8721     8721           
  Misses        780      780

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77f3e7...eb51b6d. Read the comment docs.

@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 9, 2019

ready to be merged

vkarak
vkarak reviewed Apr 9, 2019
View reviewed changes
@vkarak vkarak merged commit 791ce10 into reframe-hpc:master Apr 9, 2019
@jgphpc jgphpc deleted the gdb4hpc branch April 9, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@jgphpc jgphpc

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 2019w13

Development

Successfully merging this pull request may close these issues.

6 participants

@jgphpc @vkarak @pep8speaks @codecov-io @victorusu @teojgo